Skip to content
  • Niklas Haas's avatar
    Fix version check macros · 6fdf03e4
    Niklas Haas authored
    These were defined backwards to the usual convention.
    
     #if GLSLANG_VERSION_GREATER_THAN(11, 10, 0)
    
    This reads as "if glslang version is greater than 11.10.0" to any
    reasonable sane programmer, and should therefore expand to
    "glslang_version > macro_argument".
    
    Yet the check it references was actually written as "macro_argument >
    glslang_version", thus expressing the completely opposite condition of
    "if glslang version is *less than* 11.10.0". This is definitely
    backwards and extremely, dangerously surprising behavior to any
    programmer familiar with such version macros.
    
    I'm not sure if anybody actually ever used them. I certainly didn't, on
    account of them being backwards. I could not find a single reference to
    them on GitHub (other than in copies of this header) - every project I
    found just used the GLSLANG_VERSION_MAJOR etc. macros directly.
    6fdf03e4